Update L2 fees logic #808
Merged
Update L2 fees logic #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
reviewed
Sep 16, 2024
Comment on lines
+688
to
+694
| * Note that at the time of this implementation, the issue was autoclosed by a bot | ||
| * as a maintainer had not responded to the issue yet. Users continue to report | ||
| * the bug in the issue comments, however. | ||
| * | ||
| * All of that to say, when evaluating whether this logic is still needed in the future, | ||
| * it will likely be required to read through the issue above, rather than relying on the | ||
| * status of the github issue itself. |
There was a problem hiding this comment.
This is great!
I mean, your comment helping our future selves, the bug is so sad 🤣
alcuadrado
approved these changes
Sep 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #724
examples/fee-testerto assist with manual testinggasPriceanddisableFeeBumpingconfig fields added